[tor-bugs] #21872 [Core Tor/Tor]: encoded length macros for baseXX encodings
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Apr 7 12:41:08 UTC 2017
#21872: encoded length macros for baseXX encodings
--------------------------+------------------------------------
Reporter: catalyst | Owner: catalyst
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: util | Actual Points:
Parent ID: #19531 | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by dgoulet):
This looks good to me!
Quick question, do we have unit tests for those baseXX APIs? I'm asking
because some `tor_assert()` are being added like `tor_assert(destlen >=
BASE16_BUFSIZE(srclen));` which look safe but still useful to make sure
tor code will not blow up there :).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21872#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list