[tor-bugs] #13339 [Core Tor/Tor]: Prop140: Complete Consensus diffs / Merge GSoC project

[Tor Bug Tracker & Wiki]

#13339: Prop140: Complete Consensus diffs / Merge GSoC project
-------------------------------------------------+-------------------------
 Reporter:  mvdan                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  gsoc, merge, tor-client, prop140,    |  Actual Points:
  027-triaged-1-in, 028-triaged, pre028-patch,   |
  tor-dos, low-bandwidth, nickm-                 |
  deferred-20160905, tor-03-unspecified-201612,  |
  sponsor4, TorCoreTeam201703                    |
Parent ID:                                       |         Points:  parent
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by mvdan):

 Another thought - could be that calc_changes is buggy somewhere, causing
 it to end up with diffs that are correct but not the optimal it would find
 if it were doing divide-and-conquer properly. Perhaps
 optimal_column_to_split is wrong, or perhaps we should use its return
 value plus one or minus one instead of as-is.

 In my head, divide and conquer should be able to come up with your version
 just fine. Then again, the version it finds is just as optimal given its
 "number of lines added+deleted" heuristic.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:57>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online