[tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
-----------------------+------------------------------------
 Reporter:  mcs        |          Owner:  yawning
     Type:  defect     |         Status:  assigned
 Priority:  Medium     |      Milestone:
Component:  Core Tor   |        Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal     |     Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID:             |         Points:
 Reviewer:             |        Sponsor:
-----------------------+------------------------------------
Changes (by yawning):

 * status:  new => assigned


Comment:

 The assert still happens because we always compare addresses regardless of
 if IsolateClientAddr is set.

 This requires a few changes I think, after looking at it:

  * We need to disable `IsolateClientAddr` whne using AF_LOCAL sockets
 (Easy, done in my branch).
  * `tor_addr_compare_masked()` should probably handle AF_LOCAL sockets.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20261#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online