[tor-bugs] #19755 [Metrics/CollecTor]: improve code quality of bridgedescs module
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Sep 30 10:18:44 UTC 2016
#19755: improve code quality of bridgedescs module
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: CollecTor 1.2.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Comment (by iwakeh):
Thanks for all these tests!
Now we have a basis for the refactoring of this module.
It seemed shorter to write the code for the suggestions I had.
Please, see the seven commits in
[https://gitweb.torproject.org/user/iwakeh/collector.git?h=task-19755-2 my
branch] based on yours.
Cobertura barks on binary literals, but doesn't fail, so I would prefer to
use them.
I tried to make the commits independent of each other.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19755#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list