[tor-bugs] #20235 [Core Tor]: Configure misidentifies clock_gettime and getentropy on macOS Sierra/XCode8 when compiling for iOS 8

[Tor Bug Tracker & Wiki]

#20235: Configure misidentifies clock_gettime and getentropy on macOS Sierra/XCode8
when compiling for iOS 8
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  rainwolf               |
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:
    Component:  Core     |    Version:  Tor: 0.2.8.8
  Tor                    |   Keywords:  Sierra, XCode 8, clock_gettime,
     Severity:  Normal   |  getentropy, libSystem.dylib
Actual Points:           |  Parent ID:
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 libSystem.dylib provides clock_gettime and getentropy from iOS 10 onward
 but not below but the configure script does not detect that. Even with the
 `-Wl,-no_weak_imports`

 linker flag. The only way I managed to compile for iOS8 and iOS9 on macOS
 Sierra with XCode8 was to patch out detection of clock_gettime and
 getentropy from the configure script. This is less-than-ideal but the only
 fix I know. I attached the patch that I used on configure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20235>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online