[tor-bugs] #20228 [Metrics/CollecTor]: Append all votes with same valid-after time to a single file in `recent/`

[Tor Bug Tracker & Wiki]

#20228: Append all votes with same valid-after time to a single file in `recent/`
-----------------------------------+-----------------
     Reporter:  karsten            |      Owner:
         Type:  enhancement        |     Status:  new
     Priority:  Medium             |  Milestone:
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+-----------------
 We're currently creating a new file per vote in `recent/relay-
 descriptors/votes/`, which might be excessive.  We could easily append all
 votes with the same valid-after time to a single file there, so instead
 of:

 {{{
 2016-09-23-14-00-00-vote-
 EFCBE720AB3A82B99F9E953CD5BF50F7EEFC7B97-927994982CFB4E2F24D22D0B74D693574EC04DE5
 2016-09-23-14-00-00-vote-
 ED03BB616EB2F60BEC80151114BB25CEF515B226-915DB92F8614D94EB6390621EF4ADD65510A6AB7
 2016-09-23-14-00-00-vote-
 D586D18309DED4CD6D57C18FDB97EFA96D330566-C77126E7595C15F242DF13F740528526E71CC063
 2016-09-23-14-00-00-vote-49015F787433103580E3B66A1707A00E60F2D15B-
 1307B591CA002EB4FD55E5B183F8D757A64F0963
 2016-09-23-14-00-00-vote-
 23D15D965BC35114467363C165C4F724B64B4F66-9489196D1A9647F7A0B6CEDD3E48C7CFAECC57F0
 2016-09-23-14-00-00-vote-
 14C131DFC5C6F93646BE72FA1401C02A8DF2E8B4-8C8DEA53F89447781098CFCDA9A59ED8B6987C96
 2016-09-23-14-00-00-vote-0232AF901C31A04EE9848595AF9BB7620D4C5B2E-
 8E11EBEEC56D1DBECC9105192F0036292B35A721
 }}}

 we'd just provide a single file:

 {{{
 2016-09-23-14-00-00-votes
 }}}

 just like we're providing a single file for the consensus:

 {{{
 2016-09-23-14-00-00-consensus
 }}}

 I just looked at the `index.json` we provide, and of the 1825 files in
 `recent/`, 504 are votes (28%).  My rough estimate is that we'd cut down
 the size of `index.json` to 75% of its current size.

 The question is whether anybody downloads these votes (manually) and
 relies on them being contained in separate files.

 Note that this change would not affect how votes are stored in tarballs.
 They can stay in separate files there.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20228>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online