[tor-bugs] #20203 [Core Tor/Tor]: tor_assertion_failed on low memory

[Tor Bug Tracker & Wiki]

#20203: tor_assertion_failed on low memory
-------------------------------------------------+-------------------------
 Reporter:  tmpname0901                          |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.7
 Severity:  Major                                |     Resolution:
 Keywords:  assert 028-backpoort                 |  Actual Points:  .2
  TorCoreTeam201609                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 {{{
 +    if (/*BUG(*/ queue->n <= 0 /*)*/) {
 +      log_warn(LD_BUG, "Found a supposedly active circuit with no cells "
 +               "to send. Trying to recover.");
 +      circuitmux_set_num_cells(cmux, circ, queue->n);
 +      circuit_mark_for_close(circ, END_CIRC_REASON_INTERNAL);
 +      continue;
 +    }
 }}}
 This code will trigger one extra bug warning.
 If circuit wasn't marked for close yes (if some another bug), it will
 report:
 {{{
 "Called on non-marked circuit"
 }}}
 and skip cmux signaling and recover.

 If circuit was marked for close already, it will report:
 {{{
 "Duplicate call to circuit_mark_for_close at" ...
 }}}
 is it ok?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20203#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online