[tor-bugs] #19958 [Core Tor/Tor]: Implement proposal 264 (protocol versioning)

[Tor Bug Tracker & Wiki]

#19958: Implement proposal 264 (protocol versioning)
-----------------------------------------------+---------------------------
 Reporter:  nickm                              |          Owner:  nickm
     Type:  enhancement                        |         Status:
                                               |  needs_revision
 Priority:  High                               |      Milestone:  Tor:
                                               |  0.2.9.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  TorCoreTeam201608, review-group-9  |  Actual Points:  2
Parent ID:  #15055                             |         Points:  2
 Reviewer:  dgoulet                            |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by isis):

 * status:  needs_review => needs_revision


Comment:

 I've read through Nick's code twice now, and found no major problems
 beyond what dgoulet had already found.  I still think we should strive to
 keep the "symmetry" in networkstatus lines… other than that everything
 looks good to me.

 Nick and I on IRC spoke briefly, and Nick is worried that DirAuths might
 accidentally vote to shut themselves down due to missing required
 subprotocols.  I agree that this is worrisome, but it should be an easy
 fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19958#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online