[tor-bugs] #17904 [Applications/Tor Browser]: Use sufficient window dimensions in Privacy and Security Settings

[Tor Bug Tracker & Wiki]

#17904: Use sufficient window dimensions in Privacy and Security Settings
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Low                                  |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  tbb-security-slider,                 |  Actual Points:
  TorBrowserTeam201609R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:9 mcs]:
 > Kathy and I reviewed this and it looks good. We have just a couple of
 comments:

 Thanks for reviewing this!

 >  1. You added ids to many XUL elements, but we do not see where they are
 >  used. Are they needed? For example, you added `id="privacy_checkboxes"`
 >  Are these IDs needed?

 I actually added them because I was having trouble keeping track of nested
 XUL elements. Would you prefer if I turn them into comments?

 >  2. The preferences.xul file has no tabs except for one (which should
 >  probably be removed). Please use spaces instead of tabs to stay
 consistent
 >  with the rest of the file.

 Not sure how I ended up with tabs -- I will fix that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17904#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online