[tor-bugs] #19317 [Metrics/CollecTor]: Sanitize TCP ports in bridge descriptors

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Sep 18 19:05:37 UTC 2016


#19317: Sanitize TCP ports in bridge descriptors
-------------------------------+---------------------------------
 Reporter:  karsten            |          Owner:
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:  CollecTor 1.2.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------
Changes (by karsten):

 * priority:  Medium => High


Comment:

 Please review the last two commits in
 [https://gitweb.torproject.org/karsten/metrics-db.git/log/?h=task-19317-2
 my branch task-19317-2].  The first commit
 ([https://gitweb.torproject.org/karsten/metrics-
 db.git/commit/?h=task-19317-2&id=ecb053899eb965c2778cf05479c26549d67f7956
 ecb0538]) has the same code as the [https://gitweb.torproject.org/karsten
 /metrics-
 db.git/commit/?h=task-19317&id=c742c388da500b0f9b2df236f49d280aa2715c96
 commit in my earlier task-19317 branch], rebased to master.  Note that
 this patch doesn't include changes based on the
 [https://trac.torproject.org/projects/tor/ticket/19317#comment:8
 suggestions above], which we should make as soon as unit tests are in
 place.  The second commit ([https://gitweb.torproject.org/karsten/metrics-
 db.git/commit/?h=task-19317-2&id=f608c94c7f731241bf7ee8e627ca1da98c23d858
 f608c94]) splits tarballs into one per month and descriptor type.  I'm
 already running this code in parallel to the main CollecTor instance, and
 I'm ready to switch over as soon as 1) the tarball samples I sent you look
 okay and 2) this branch is ready to be merged.  By the way, I'd say we
 don't need to put out a release for this, but I can as well run a -dev
 version on the primary CollecTor instance.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19317#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list