[tor-bugs] #20138 [Core Tor/Trunnel]: Add constified getters to trunnel

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Sep 15 10:49:59 UTC 2016


#20138: Add constified getters to trunnel
------------------------------+------------------------------
 Reporter:  asn               |          Owner:  nickm
     Type:  task              |         Status:  needs_review
 Priority:  Medium            |      Milestone:
Component:  Core Tor/Trunnel  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  trunnel           |  Actual Points:
Parent ID:                    |         Points:  .5
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------

Comment (by asn):

 Yes, this is precisely what I had in mind indeed!

 I tried your branch on my #19043 branch and it worked fine.
 I managed to constify three getters that were previously impossible to
 constify.


 I almost feel like the const getter should be the default, and one should
 call a mutable function to get a non-const pointer. But this is probably
 too big of a change for now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20138#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list