[tor-bugs] #19958 [Core Tor/Tor]: Implement proposal 264 (protocol versioning)

[Tor Bug Tracker & Wiki]

#19958: Implement proposal 264 (protocol versioning)
-----------------------------------------------+---------------------------
 Reporter:  nickm                              |          Owner:  nickm
     Type:  enhancement                        |         Status:
                                               |  needs_revision
 Priority:  High                               |      Milestone:  Tor:
                                               |  0.2.9.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  TorCoreTeam201608, review-group-8  |  Actual Points:  2
Parent ID:  #15055                             |         Points:  2
 Reviewer:  dgoulet                            |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by nickm):

 Okay, I believe I've responded to your review items.

 I am okay with *changing* these versions, but have a look at this
 paragraph:

 {{{
    Because all relays currently on the network are 0.2.4.19 or later, we
    can require 0.2.4.19, and use 0.2.4.19 as the minimal version so we
    we don't need to do code archaeology to determine how many
    no-longer-relevant versions of each protocol once existed.
 }}}

 I like the idea of keeping the versions in sync, but there's not a point
 to giving names for versions that only old clients use.

 What do you think of my torspec changes in `dgoulet_ticket19958_01` ?
 (Based on your branch)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19958#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online