[tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8                                        |
Parent ID:                                       |         Points:  .2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Replying to [comment:14 asn]:
 > Review:
  [...]

 Thanks!

 I've fixed the typo issues and squashed the commits in a new branch,
 `ticket20001_v2`.  It has also been rebased to master.  I've added a unit
 test in a second commit.

 > - As a step further, does this mean that we can eventually deprecate the
 `is_valid` and `is_flagged_running` flags, and assume that they are set?
 When can this be done? I guess we can already do this for `is_valid` but
 we need to wait till `MIN_METHOD_FOR_EXCLUDING_INVALID_NODES` becomes
 standard to remove `is_flagged_running`.

 I think you have those backwards, but yeah. We could do that eventually.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20001#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online