[tor-bugs] #17178 [Core Tor/Tor]: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous

[Tor Bug Tracker & Wiki]

#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rsos, tor-hs, TorCoreTeam201609,     |  Actual Points:  14
  review-group-5, review-group-8                 |
Parent ID:                                       |         Points:  6.5
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * keywords:
     rsos, tor-hs, TorCoreTeam201608, TorCoreTeam201609, review-group-5,
     review-group-8
     => rsos, tor-hs, TorCoreTeam201609, review-group-5, review-group-8
 * actualpoints:  13.5 => 14


Comment:

 I have made the changes nickm requested in his gitlab review, and added
 comments on gitlab with those commits.

 The changes in my [comment:84 comment:84] are in:
 [feature-17178-v7 16c1a3a] Refactor Single Onion code to improve
 consistency

 The changes in dgoulet's [comment:88 comment:88] are in:
 [feature-17178-v7 f4d938c] Replace OnionService* with HiddenService* in
 option names

 So I think this is it. lgtm?
 I am happy to do a not-so-auto-squash once everyone is happy.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:89>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online