[tor-bugs] #19958 [Core Tor/Tor]: Implement proposal 264 (protocol versioning)

[Tor Bug Tracker & Wiki]

#19958: Implement proposal 264 (protocol versioning)
-----------------------------------------------+---------------------------
 Reporter:  nickm                              |          Owner:  nickm
     Type:  enhancement                        |         Status:
                                               |  needs_revision
 Priority:  High                               |      Milestone:  Tor:
                                               |  0.2.9.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  TorCoreTeam201608, review-group-8  |  Actual Points:  2
Parent ID:  #15055                             |         Points:  2
 Reviewer:  dgoulet                            |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by dgoulet):

 Replying to [comment:8 nickm]:
 > I think separate values for IP and RP is fine.  So, HSIntroPoint,
 HSRendPoint?

 That sounds good to me. We could also shrink those to save "bytes" I guess
 with like `HSip` and `HSrp` but no strong opinion here.

 >
 > WRT the other ones, could you attach a patch to the proposal so I
 understand what you're suggestiong?
 >

 Sure will try to do that asap.

 > It doesn't make sense for "recommended" to be more narrow than
 "required" -- "required" means "exit if you don't have these" and
 "recommended" means "warn if you don't have these".

 I think I got that correctly. In this particular case, v0 and v1 are
 "obsolete" that is no tor uses it but relay still can handle it... so we
 recommend "2 and 3" but require "0 to 3" because we don't want to cut v0
 and v1 yet. That was my reasoning but might be really bad...

 However, if this comes from the consensus I can't see any harm of doing so
 rather than abruptly ripping off v0 and v1 from tor and receiving a 404
 error when you try v1 for instance on an HSDir leading to "version
 discovery".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19958#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online