[tor-bugs] #18093 [Applications/Tor Browser]: Torbutton UI flow improvement

[Tor Bug Tracker & Wiki]

#18093: Torbutton UI flow improvement
-------------------------------------------------+-------------------------
 Reporter:  bugzilla                             |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-usability, tbb-torbutton, tbb-   |  Actual Points:
  security-slider, TorBrowserTeam201609          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by brade):

 * cc: brade, mcs (added)


Comment:

 Replying to [comment:6 arthuredelstein]:
 > Any opinions on this?

 As of 1b41636c9351b46bbcb2094a65c65a4407b60a37 (the fix for #15852), the
 browser proxy preferences are not reset. I guess the "2. Clear browser
 proxy settings" should have been replaced with "2. Reset some browser
 preferences" (or with a comment that more accurately describes what
 torbutton_reset_browser_prefs() does).

 I do not know the history of "Restore Defaults" and I am not sure how the
 list of preferences that is hard-coded into
 torbutton_reset_browser_prefs() was generated, but I agree that if we are
 going to change more settings that those that are controlled from that
 dialog we should remove the button and make this feature accessible from
 somewhere else.

 Do we need this feature? I wonder how many people need it? Or as bugzilla
 suggests, maybe we should we fix #19135 instead? Note that "Refresh Tor
 Browser" may work correctly on OSX now that we have moved the browser
 profile out of the .app area and made it so the browser can create a
 working profile during startup.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18093#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online