[tor-bugs] #13827 [Core Tor/Tor]: Cell handling code duplication in channel.c

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Sep 11 01:29:37 UTC 2016


#13827: Cell handling code duplication in channel.c
------------------------------+----------------------------------
 Reporter:  rl1987            |          Owner:  rl1987
     Type:  defect            |         Status:  accepted
 Priority:  Medium            |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor      |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  refactoring easy  |  Actual Points:
Parent ID:                    |         Points:  small/medium
 Reviewer:                    |        Sponsor:
------------------------------+----------------------------------

Comment (by pingl):

 `channel_write_cell()`, `channel_write_packed_cell()` and
 `channel_write_var_cell()` are combined into the `channel_write()`
 function that takes as a 3rd argument the cell type. That's defined in
 channel.h as enum with 3 possible values: CELL, PACKED_CELL, VAR_CELL.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13827#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list