[tor-bugs] #18093 [Applications/Tor Browser]: Torbutton UI flow improvement

[Tor Bug Tracker & Wiki]

#18093: Torbutton UI flow improvement
-------------------------------------------------+-------------------------
 Reporter:  bugzilla                             |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-usability, tbb-torbutton, tbb-   |  Actual Points:
  security-slider, TorBrowserTeam201609          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  accepted => needs_information


Comment:

 The "Restore Defaults" button runs torbutton_prefs_reset_defaults in
 preferences.js. The comment there says the function will
 {{{
  //  1. Clear torbutton settings
  //  2. Clear browser proxy settings
  //  3. Reset Security Slider settings
 }}}

 Because this does much more than simply reset the security slider and
 privacy settings visible in the window, the button is confusing. It's also
 unclear to the user what settings "Restore Defaults" will restore -- all
 Firefox prefs are not restored; only some select ones hardcoded in
 torbutton.

 So I can think of a few alternative designs:

 1. Make "Restore Defaults" apply only to the Security Slider and privacy
 checkboxes in the Privacy and Security Settings window.
 2. Move "Restore Defaults" to the main torbutton menu, to avoid confusing
 it with the Privacy and Security settings. (We could also consider
 restoring ALL prefs to default, instead of an arbitrary few.)
 3. Remove the "Restore Defaults" button altogether.

 I lean toward option 2.

 If we do retain the "Restore Defaults" button, we should probably show a
 confirm dialog. We should also add a tooltip explaining exactly what the
 button does.

 Any opinions on this?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18093#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online