[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Sep 7 12:11:19 UTC 2016
#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
| arthuredelstein
Type: task | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-torbutton-conversion, | Actual Points:
TorBrowserTeam201609 |
Parent ID: | Points:
Reviewer: | Sponsor:
| SponsorU
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-torbutton-conversion, TorBrowserTeam201609R => tbb-
torbutton-conversion, TorBrowserTeam201609
* status: needs_review => needs_revision
Comment:
Okay, I gave v7 another round of testing. On OS X my issue is gone,
thanks! On Windows it basically remains: The width is good but the height
is off (I get 730px or 710px).
Two additional things I'd like to see addressed:
1) When maximizing (e.g. by chance) and restarting the window is not
resized to sane defaults. We should do that, though, at least until
something for #14429 lands.
2) I realized you set `maxWidth` to `1200`. While I generally think it
could be smart to revisit the decision to cap that value at `1000`, I'd
like to see this happening in a different ticket. There we could think
about a new `maxWidth` value based on real data. This would help making
this move more transparent as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list