[tor-bugs] #17178 [Core Tor/Tor]: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous

[Tor Bug Tracker & Wiki]

#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rsos, tor-hs, TorCoreTeam201608,     |  Actual Points:  13.5
  TorCoreTeam201609, review-group-5, review-     |
  group-8                                        |
Parent ID:                                       |         Points:  6.5
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * actualpoints:  13 => 13.5


Comment:

 The ADD_ONION flag is "NonAnonymous".

 [feature-17178-v7 7406391] Ephemeral Single Onion Services must have the
 NonAnonymous ADD_ONION flag

 There are no ADD_ONION unit tests, so I tested it using:

 {{{
 stem/tor-prompt --tor src/or/tor
 ADD_ONION NEW:BEST Flags=DiscardPK Port=22
 ADD_ONION NEW:BEST Flags=DiscardPK,NonAnonymous Port=22
 }}}

 {{{
 tor/src/or/tor DataDirectory /tmp/tor.$$ ControlPort 2000
 OnionServiceSingleHopMode 1 OnionServiceNonAnonymousMode 1 SOCKSPort 0
 stem/tor-prompt -i 2000
 ADD_ONION NEW:BEST Flags=DiscardPK Port=22
 ADD_ONION NEW:BEST Flags=DiscardPK,NonAnonymous Port=22
 }}}

 And the responses are as specified in #20094.

 All the existing tests passed after these changes, including:
 * unit tests,
 * chutney make test-network-all,
 * chutney single-onion, single-onion-indirect, single-onion-ipv6, and
 single-onion-client-ipv6 from #17622 / #20072,
 * chutney client-ipv6-only, hs-ipv6 and hs-client-ipv6 from #17812 /
 #20069.

 I think we're done with changes here, the only one I declined was to
 change the option names to something containing "Hidden", mainly because
 it's hard to say "NonHiddenService" in a way that's understandable. I
 believe the correct fix for this is to alias all the other option names
 from HiddenService to OnionService, which will happen with prop224.

 The existing GitLab merge request has had 29 commits added, typically one
 per review comment.
 I have responded to each comment with the commit hash.
 The fixup! chain gets quite ridiculous, sorry about that.
 https://gitlab.com/teor/tor/merge_requests/8

 I am happy to fixup/squash these before merge, once you're happy with the
 branch. I was careful to try to make sure that they all squashed cleanly,
 but there's always one...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:81>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online