[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Sep 7 01:06:31 UTC 2016


#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201609                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:12 gk]:
 > So, I tested this on my OS X testbox and I get always on a very first
 start 789x600. After New Identity 1200x600 shows up which is okay. After
 restarting I get most of the time 1200x600 but sometimes I end up with
 335[sic!]x600. I've uploaded everything for reproducing the bug:

 Thanks for testing this. I don't know why, but it seems Tor Browser builds
 the chrome window differently on first launch, before a profile has been
 created. Also, weirdly, while I could see the same first-launch window
 sizing behavior using your TorBrowser.app build, I couldn't reproduce it
 with my own tor-browser.git `./mach build`. I was able to experiment by
 editing the browser.js inside your TorBrowser.app and find a way to
 accommodate both modes of building the window.

 Also I now realize I don't need to use the flex attribute at all, so that
 simplifies things a little further.

 Here is the new version. I have tested on OS X and Linux, but not Windows
 yet:
 https://github.com/arthuredelstein/tor-browser/commit/19459+7

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list