[tor-bugs] #20079 [Metrics/CollecTor]: Change log thresholds from TRACE to INFO

[Tor Bug Tracker & Wiki]

#20079: Change log thresholds from TRACE to INFO
-----------------------------------+-----------------------------
     Reporter:  karsten            |      Owner:
         Type:  enhancement        |     Status:  new
     Priority:  Medium             |  Milestone:  CollecTor 1.1.0
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+-----------------------------
 Turns out that CollecTor's torperf module is rather chatty when it comes
 to logging.  In the past few days it produced 39G of logs, of which only
 876k were higher than TRACE and DEBUG.  This didn't come to my attention
 earlier, because I simply didn't log those lines before upgrading to
 latest master.  I think this is rather surprising for new CollecTor
 operators, and I wonder if we should change the default from TRACE to
 INFO.  If an operator wants to debug a problem, they can always switch to
 a lower log level.

 Suggested patch:

 {{{
 diff --git a/src/main/resources/logback.xml
 b/src/main/resources/logback.xml
 index 2d8a1ce..82e52ab 100644
 --- a/src/main/resources/logback.xml
 +++ b/src/main/resources/logback.xml
 @@ -40,6 +40,9 @@
          <maxFileSize>1MB</maxFileSize>
        </timeBasedFileNamingAndTriggeringPolicy>
      </rollingPolicy>
 +    <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
 +      <level>INFO</level>
 +    </filter>
    </appender>

    <appender name="FILEBRIDGEDESCS"
 class="ch.qos.logback.core.FileAppender">
 @@ -49,7 +52,7 @@
      </encoder>

      <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
 -      <level>TRACE</level>
 +      <level>INFO</level>
      </filter>
    </appender>

 @@ -60,7 +63,7 @@
      </encoder>

      <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
 -      <level>TRACE</level>
 +      <level>INFO</level>
      </filter>
    </appender>

 @@ -71,7 +74,7 @@
      </encoder>

      <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
 -      <level>TRACE</level>
 +      <level>INFO</level>
      </filter>
    </appender>

 @@ -82,7 +85,7 @@
      </encoder>

      <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
 -      <level>TRACE</level>
 +      <level>INFO</level>
      </filter>
    </appender>

 }}}

 What do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20079>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online