[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 6 09:01:15 UTC 2016


#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201609R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 So, I tested this on my OS X testbox and I get always on a very first
 start 789x600. After New Identity 1200x600 shows up which is okay. After
 restarting I get most of the time 1200x600 but sometimes I end up with
 335[sic!]x600. I've uploaded everything for reproducing the bug:

 https://people.torproject.org/~gk/testbuilds/19459/TorBrowser-tbb-nightly-
 osx64_ALL_19459.dmg
 https://people.torproject.org/~gk/testbuilds/19459/TorBrowser-tbb-nightly-
 osx64_ALL_19459.dmg.asc
 https://people.torproject.org/~gk/testbuilds/19459/tor-
 launcher-0.2.8.5.xpi
 https://people.torproject.org/~gk/testbuilds/19459/tor-
 launcher-0.2.8.5.xpi.asc
 https://people.torproject.org/~gk/testbuilds/19459/torbutton-1.9.6.1.xpi
 https://people.torproject.org/~gk/testbuilds/19459/torbutton-1.9.6.1.xpi.asc

 I extracted the .dmg file on my Desktop, made sure there is no old
 TorBrowser-Data dir and copied the extensions over (Torbutton contains
 your patch on top of master and TorLauncher contains fixes for #20075 and
 #20076). The extensions are in Contents/Resources/distribution/extensions.
 Then I started Tor Browser.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list