[tor-bugs] #20004 [Core Tor/Tor]: prop224: Add a trunnel subdirectory specifically for HS

[Tor Bug Tracker & Wiki]

#20004: prop224: Add a trunnel subdirectory specifically for HS
------------------------------------------------+--------------------------
 Reporter:  dgoulet                             |          Owner:  dgoulet
     Type:  enhancement                         |         Status:
                                                |  needs_review
 Priority:  High                                |      Milestone:  Tor:
                                                |  0.3.0.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201610  |  Actual Points:  0.5
Parent ID:  #17241                              |         Points:  1
 Reviewer:  asn                                 |        Sponsor:
                                                |  SponsorR-must
------------------------------------------------+--------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Hello,

 please see my branch `ticket20004_rebased`. It's basically David's branch
 with the following changes:
 - It's rebased to latest tor git master.
 - It's rebased to latest trunnel git master.
 - It fixes the issues pointed out in comment:10 and comment:11.


 (WRT comment:11, the patch does not actually add the MAC field to the
 encrypted part of `INTRODUCE1`, as the current format is:
 {{{
           CLIENT_PK                [G_LEN bytes]
           ENCRYPTED_DATA           [Padded to length of plaintext]
           MAC                      [MAC_LEN bytes]
 }}}
 and there is no way to specify `Padded to length of plaintext` in trunnel
 when it's not the last element in the struct AFAIK. During implementation,
 we can do this parsing on our own, or if we want trunnel to do it for us,
 we should probably add an ENCRYPTED_DATA_LEN field.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20004#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online