[tor-bugs] #19969 [Core Tor/Tor]: tor client does not immediately open new circuits after standby

[Tor Bug Tracker & Wiki]

#19969: tor client does not immediately open new circuits after standby
-------------------------------------------------+-------------------------
 Reporter:  weasel                               |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.6
 Severity:  Normal                               |     Resolution:
 Keywords:  regression 029-backport              |  Actual Points:
  028-backport                                   |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Replying to [comment:21 arma]:
 > Replying to [comment:19 arma]:
 > > That actually gives a suggestion for a third avenue for a fix -- in
 connection_ap_mark_as_pending_circuit_(), we add one of those calls to
 tor_event_base_loopexit(). Would that be simpler or am I mistaken?
 >
 > My {{{bug19969_028_alt}}} branch implements this option. I found it
 useful to write to make sure I understood what was going on, so I will be
 totally fine if you pick your branch as being the less messy / more safe
 one. :)

 That's actually a little bad: calling event_base_loopexit() over and over
 like that is not idempotent.  Instead, it creates "exit the loop" events
 proportional to the number of times you call it.  That's not ''super''
 harmful, but it does mean allocate more RAM and waste more CPU than one
 might want.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19969#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online