[tor-bugs] #19969 [Core Tor/Tor]: tor client does not immediately open new circuits after standby

[Tor Bug Tracker & Wiki]

#19969: tor client does not immediately open new circuits after standby
-------------------------------------------------+-------------------------
 Reporter:  weasel                               |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.6
 Severity:  Normal                               |     Resolution:
 Keywords:  regression 029-backport              |  Actual Points:
  028-backport                                   |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Replying to [comment:20 teor]:
 > Replying to [comment:18 arma]:
 > > ...
 > > 2)
 > > {{{
 > >   /* Make sure we know (about) what time it is. */
 > >   update_approx_time(time(NULL));
 > > }}}
 > > No worries, this one happens in second_elapsed_callback() too.
 > > ...
 >
 > I wouldn't be so quick to brush this one off.
 >
 > It could well the cause of #20423, which occurred when a relay operator
 on FreeBSD/LibreSSL upgraded to 0.2.8, and went away again when they
 reverted to 0.2.7.

 I've looked at it some more, and I don't think it should be the cause of
 anything. The issue is that while we used to think that we update our
 approx time around once a second and also after a burst of event callbacks
 finishes, it turns out we only update it around once a second plus during
 the (relatively rare) times where we have a linked conn that wants to
 read. So I don't think that should be related to #20423.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19969#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online