[tor-bugs] #18873 [Core Tor/Tor]: Refactor circuit_predict_and_launch_new()

[Tor Bug Tracker & Wiki]

#18873: Refactor circuit_predict_and_launch_new()
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  Low           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  refactoring   |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:11 chelseakomlo]:
 > Ok, great, that is good everything checks out for that refactor, thanks!
 >
 > Let me know if you have further recommendations for better naming or
 anything else that can be extracted from circuit_predict_and_launch_new. I
 can look at adding more unit tests, to needs_hs_client_circuits and
 circuit_predict_and_launch_new as well.

 I think this looks good, and can be merged as-is. But I'd like someone
 else to review it too.

 > I can help with investigating how the behavior could be improved, but it
 would be good to get some ideas on how to start. I.e, what constitutes
 better/worse behavior.

 Given the length of this ticket, I'd put behaviour changes in another
 ticket.
 For example, there are existing tickets relating to this function: an
 enhancement in #17360, and a bug in #17359.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18873#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online