[tor-bugs] #20494 [Core Tor/Tor]: connection_ap_handshake_rewrite_and_attach: This line should not have been reached

[Tor Bug Tracker & Wiki]

#20494: connection_ap_handshake_rewrite_and_attach: This line should not have been
reached
--------------------------+----------------------------------------
 Reporter:  mcs           |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.0.0-alpha-dev
 Severity:  Normal        |     Resolution:
 Keywords:  tbb-needs     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------------

Comment (by nickm):

 Ha, that's totally my fault.

 I added it in f3e158edf7d8128, because the code used to say:
 {{{
 -    /* No else, we've covered all possible returned value. */
 }}}

 Looks like that wasn't true in the sense I had thought.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20494#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online