[tor-bugs] #20484 [Core Tor/Tor]: HiddenServiceDir must already exist when making a Single Onion Service

[Tor Bug Tracker & Wiki]

#20484: HiddenServiceDir must already exist when making a Single Onion Service
----------------------------------+------------------------------------
 Reporter:  pastly                |          Owner:
     Type:  defect                |         Status:  new
 Priority:  Medium                |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.2.9.3-alpha
 Severity:  Normal                |     Resolution:
 Keywords:  tor-hs, single-onion  |  Actual Points:
Parent ID:                        |         Points:  0.2
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by teor):

 Ah, you're right, this works fine for me:
 {{{
 src/or/tor HiddenServiceDir `mktemp -d` HiddenServicePort 80 DataDirectory
 `mktemp -d`
 }}}

 As does this:
 {{{
 src/or/tor HiddenServiceDir `mktemp -d` HiddenServicePort 80 DataDirectory
 `mktemp -d` HiddenServiceNonAnonymousMode 1 HiddenServiceSingleHopMode 1
 SocksPort 0
 }}}

 And this:
 {{{
 src/or/tor HiddenServiceDir `mktemp -d -u` HiddenServicePort 80
 DataDirectory `mktemp -d -u`
 }}}

 But not this:
 {{{
 src/or/tor HiddenServiceDir `mktemp -d -u` HiddenServicePort 80
 DataDirectory `mktemp -d -u` HiddenServiceNonAnonymousMode 1
 HiddenServiceSingleHopMode 1 SocksPort 0
 }}}

 So we need to do this:

 * Call the code that creates the directory before trying to poison single
 onion services

 And we might as well fix #20486 at the same time (document that the
 directory does not need to exist).

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20484#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online