[tor-bugs] #20472 [Core Tor/Tor]: circuit_pick_extend_handshake: Non-fatal assertion !(node_prev == NULL) failed

[Tor Bug Tracker & Wiki]

#20472: circuit_pick_extend_handshake: Non-fatal assertion !(node_prev == NULL)
failed
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.3-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  TorCoreTeam201610, regression,       |  Actual Points:  0.3
  029-backport                                   |
Parent ID:                                       |         Points:  0.3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  new => needs_review
 * keywords:  TorCoreTeam201610, regression => TorCoreTeam201610,
     regression, 029-backport
 * points:   => 0.3
 * actualpoints:   => 0.3


Comment:

 See my branch bug20472-029, which also merges cleanly into master:
 * remove the bug warning
 * don't assume that nodes with unknown versions support EXTEND2 cells
 * rename the supports_ntor function to avoid confusion between EXTEND2 and
 ntor support

 This passes make test-full on master and make check test-network-all
 0.2.9, except for #20476 and #20477, which appear to be unrelated.

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20472#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online