[tor-bugs] #20475 [Metrics/Torflow]: Setting bwscanner min_exits to 1 causes no exits to be selected

[Tor Bug Tracker & Wiki]

#20475: Setting bwscanner min_exits to 1 causes no exits to be selected
---------------------------------+--------------------
     Reporter:  teor             |      Owner:  aagbsn
         Type:  defect           |     Status:  new
     Priority:  Medium           |  Milestone:
    Component:  Metrics/Torflow  |    Version:
     Severity:  Normal           |   Keywords:
Actual Points:                   |  Parent ID:
       Points:                   |   Reviewer:
      Sponsor:                   |
---------------------------------+--------------------
 It looks like there's an off-by-one error in the code that handles this
 minimun:
 {{{
 diff --git a/NetworkScanners/BwAuthority/bwauthority_child.py
 b/NetworkScanners/BwAuthority/bwauthority_child.py
 index a36728f..248c6d0 100755
 --- a/NetworkScanners/BwAuthority/bwauthority_child.py
 +++ b/NetworkScanners/BwAuthority/bwauthority_child.py
 @@ -67,7 +68,7 @@ __selmgr = PathSupport.SelectionManager(
       use_guards=False,
       exit_ports=[443],
       order_by_ratio=True, # XXX: may be a poor idea for PID control?
 -      min_exits=10)
 +      min_exits=1)

 # exit code to indicate scan completion
 # make sure to update this in bwauthority.py as well
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20475>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online