[tor-bugs] #20410 [Core Tor/Tor]: Tor master breaks bridge clients

[Tor Bug Tracker & Wiki]

#20410: Tor master breaks bridge clients
---------------------------------+----------------------------------------
 Reporter:  teor                 |          Owner:
     Type:  defect               |         Status:  needs_revision
 Priority:  High                 |      Milestone:
Component:  Core Tor/Tor         |        Version:  Tor: 0.3.0.0-alpha-dev
 Severity:  Major                |     Resolution:
 Keywords:  crash bridge-client  |  Actual Points:
Parent ID:                       |         Points:  0.5
 Reviewer:                       |        Sponsor:
---------------------------------+----------------------------------------
Changes (by teor):

 * status:  new => needs_revision


Comment:

 make test-network-all passes everything, with the following patch on top
 of nickm's branch:

 {{{
 diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
 index faf658c..1ee0c0f 100644
 --- a/src/or/connection_edge.c
 +++ b/src/or/connection_edge.c
 @@ -2434,7 +2434,8 @@
 connection_ap_handshake_send_begin(entry_connection_t *ap_conn)
       * Otherwise, directory connections are typically one-hop.
       * This matches the earlier check for directory connection path
 anonymity
       * in directory_initiate_command_rend(). */
 -    if (purpose_needs_anonymity(linked_dir_conn_base->purpose, 0,
 +    if (purpose_needs_anonymity(linked_dir_conn_base->purpose,
 +                    TO_DIR_CONN(linked_dir_conn_base)->router_purpose,
 TO_DIR_CONN(linked_dir_conn_base)->requested_resource)) {
        assert_circ_anonymity_ok(circ, options);
      }
 }}}

 I'd like to see this merged soon, we're already getting duplicate bug
 reports.

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20410#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online