[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes

[Tor Bug Tracker & Wiki]

#20458: Integration tests should be run locally before committing code changes
--------------------------+------------------------------------
 Reporter:  chelseakomlo  |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  test, doc     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [ticket:20458 chelseakomlo]:
 > Two changes could help with this:
 > 1. Adding this information to documentation for contributors
 There is already documentation in
 [https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md?id=01482e30ad8a453f3721ef17a4a9633806b90684#n12
 CodingStandards.md].
 > 2. Adding a make task that runs all necessary tasks before contributing
 new code
 `make check` is the default target for running tests so I'd move every
 test under this target. This will also make the jenkins builds run these
 tests automatically, making catching issues easier. I would even go
 further and encourage people to run `make distcheck` which tests whether
 the distribution works (see
 https://www.gnu.org/software/automake/manual/automake.html#Checking-the-
 Distribution).

 Lastly, integrating `make check-spaces` into the distribution process has
 also been discussed in #5500.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online