[tor-bugs] #20460 [Core Tor/Tor]: tortls test failures with recent LibreSSL (OpenBSD -current)

[Tor Bug Tracker & Wiki]

#20460: tortls test failures with recent LibreSSL (OpenBSD -current)
------------------------------+------------------------------------
     Reporter:  rubiate       |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.0.0-alpha-dev
     Severity:  Normal        |   Keywords:  libressl openbsd
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------------
 Some tortls tests will segfault with recent LibreSSL

 {{{
     tortls/classify_client_ciphers: [forking] [Lost connection!]
       [classify_client_ciphers FAILED]
     tortls/client_is_using_v2_ciphers: [forking] [Lost connection!]
       [client_is_using_v2_ciphers FAILED]
     [...]
     tortls/session_secret_cb: [forking] [Lost connection!]
       [session_secret_cb FAILED]
 }}}

 The tests all do something like this:

   one = get_cipher_by_name("ECDH-RSA-AES256-GCM-SHA384");
   one->id = 0x00ff;

 The problem is LibreSSL has removed support for ECDH ciphers
 (https://marc.info/?l=openbsd-cvs&m=147689515531541&w=2), so
 get_cipher_by_name() returns NULL.

 This isn't in any released LibreSSL version yet but is in OpenBSD
 -current.

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20460>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online