[tor-bugs] #20048 [Core Tor/Tor]: Introduce `smartlist_add_strdup()` function

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Oct 24 10:48:25 UTC 2016


#20048: Introduce `smartlist_add_strdup()` function
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:  0.3
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_revision
 * type:  task => enhancement
 * milestone:  Tor: 0.2.??? => Tor: 0.3.0.x-final


Comment:

 Looks good to me, but needs a change file.
 See
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n56

 Typically, we do 2 commits for an automated change like this: one to set
 up the new function, and one big one where the automated script is applied
 (and included in the commit message). That way, anyone can verify the big
 commit by running the coccinelle script again.

 I'm not sure why we'd want to shorten the tests.

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20048#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list