[tor-bugs] #20388 [Applications/Tor Browser]: Consolidate prefs usage in torbutton.js

[Tor Bug Tracker & Wiki]

#20388: Consolidate prefs usage in torbutton.js
------------------------------------------+------------------------------
     Reporter:  arthuredelstein           |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Minor                     |   Keywords:  tbb-code-cleanup
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+------------------------------
 In torbutton.js, we call
 {{{
 var pref_service = Components.classes["@mozilla.org/preferences-
 service;1"]
     .getService(Components.interfaces.nsIPrefBranch);
 }}}
 or
 {{{
     m_tb_prefs =  Components.classes["@mozilla.org/preferences-service;1"]
         .getService(Components.interfaces.nsIPrefBranch);
 }}}
 7 times when that functionality is already available in `Services.prefs`.
 So I am proposing to consolidate this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20388>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online