[tor-bugs] #18910 [Metrics/CollecTor]: distributing descriptors accross CollecTor instances

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Oct 13 07:06:20 UTC 2016


#18910: distributing descriptors accross CollecTor instances
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Replying to [comment:41 iwakeh]:
 > Replying to [comment:40 karsten]:
 > > ...
 > >  - Should we hold back the four `*Sync*` options until there's actual
 support for syncing?  I don't feel strongly about this, because we're
 going to add syncing support really soon.  But just in case you say "oh
 wow, I totally forgot to take them out, let me fix that!", okay.  Either
 way works for me.
 >
 > I extended the commit comment (see link below).
 >
 > >
 > >  - The new options `RelayLocalOrigins` and `BridgeLocalOrigins` each
 only accept a single path.  Should we rename them to singular then?
 Again, don't feel strongly.
 >
 > Thought about that , too, but finally decided to keep it a *Options.
 >
 > >
 > >  - The new option `BridgeSources` does not support `Remote` as stated
 in the comment of `collector.properties`.
 >
 > Corrected in
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-18910
 -first-sync-2&id=02681a4d9722bfb21516693366be194c90910e5b here] (amended).

 Cherry-picked and pushed to master.  Thanks!

 > >  - Totally unrelated to this commit: should we kill the updateindex
 module and instead have an `IndexManager` with a `synchronized update()`
 method that gets called at the end of each module?  Happy to move this to
 another ticket, but it just came to mind while looking at all the
 options...
 >
 > Currently, there is also the create tars script changing the file
 structure.  This should become java code.  => new ticket?

 Yes, please.

 > Index-update could then be changed from being a module into a feature of
 module runs.  => second ticket?

 Yes, please.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18910#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list