[tor-bugs] #20077 [Core Tor/Tor]: Make is_sensitive_dir_purpose and purpose_needs_anonymity consistent

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Oct 13 01:33:46 UTC 2016

#20077: Make is_sensitive_dir_purpose and purpose_needs_anonymity consistent
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  refactor, 030-proposed,              |  Actual Points:
  TorCoreTeam201610                              |
Parent ID:                                       |         Points:  1
 Reviewer:  teor                                 |        Sponsor:

Comment (by chelseakomlo):

 Ok! Here are the latest changes.


 I had one question when doing this:

 Outside of directory.c, this functionality is used in two other places,
 neither of which test whether the router purpose is a bridge (as is done
 throughout directory.c).

 Specifically, this change feels slightly dirty:

 But I'm not sure if making two interfaces for this (one specifically for
 callers who only want to check the dir_purpose) is overkill.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20077#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list