[tor-bugs] #18910 [Metrics/CollecTor]: distributing descriptors accross CollecTor instances

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 12 18:15:48 UTC 2016


#18910: distributing descriptors accross CollecTor instances
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by iwakeh):

 Replying to [comment:37 karsten]:
 > And here are the last three commits from your initial branch, starting
 with 5eb89c1:

 Thanks for working your way through and all the useful
 comments/suggestions!
 (I still need to reply to some.)

 >
 >  - Looks good, modulo whitespace issues that should become visible with
 checkstyle.

 The commits in the second branch all are checkstyle-compliant.

 >
 > And 4722ba1:
 >
 >  - I'd want to avoid merging this and instead investigate the problem
 further.  How would I reproduce the OOM?  Run the previous commit with
 syncing from the main CollecTor instance and wait for how many hours?

 Yes, use the collector jar from the previous commit.  Run it in a new
 location, i.e. with empty recent and out.  Configure relaydescs and sync.
 RunOnce will be sufficient the OOM heap dump contains very many Reference
 objects.  (Your assumption in one of the previous comments hinted in the
 right direction, I think, but I couldn't verify that yet.)

 The sync into an empty place approximately takes an hour depending on the
 internet connection.

 >
 > Last and probably least, d2fcb1b:
 >
 >  - We should simply squash this one into the earlier commit that added
 these lines.  And we should add a note to `collector.properties` that
 microdescs are exempt from syncing.  And we should create a ticket as a
 reminder to add microdescs to the sync part later on.

 I just don't add microdescs-sync to the new branch in first place and will
 open the new ticket.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18910#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list