[tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
-----------------------+------------------------------------
 Reporter:  mcs        |          Owner:  yawning
     Type:  defect     |         Status:  needs_review
 Priority:  High       |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |        Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal     |     Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID:             |         Points:
 Reviewer:             |        Sponsor:
-----------------------+------------------------------------

Comment (by nickm):

 Looks good to me, but I have one question.

 In case there are other places in the code --or there later become places
 in the code! -- where we compare two AF_UNIX addresses, maybe we should
 make them turn out _unequal_ by default?  I think that missing a match is
 probably safer than reporting a spurious match, right?  If you agree, I'll
 switch the hack to do a pointer comparison.

 (Also, a note on tor_addr_t : the main reason to use tor_addr_t at all,
 instead of sockaddr_storage, was to keep it small in the case where we
 need to create a zillion of them. So if we're going to make AF_UNIX
 firstclass, we'll need some other approach to keeping it small.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20261#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online