[tor-bugs] #20077 [Core Tor/Tor]: Make is_sensitive_dir_purpose and purpose_needs_anonymity consistent

[Tor Bug Tracker & Wiki]

#20077: Make is_sensitive_dir_purpose and purpose_needs_anonymity consistent
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.???
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  refactor, 030-proposed,              |  Actual Points:
  TorCoreTeam201610                              |
Parent ID:                                       |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  refactor => refactor, 030-proposed, TorCoreTeam201610
 * reviewer:   => teor
 * status:  new => needs_revision


Comment:

 Hi, thanks for this patch!

 In general, it looks great, and I would really like to get rid of
 is_sensitive_dir_purpose. But I think we need to keep router_purpose in
 purpose_needs_anonymity.
 Otherwise, we change the logic from:
 * if you're a bridge, do everything anonymously,
 * otherwise, do some things non-anonymously,
 * otherwise, do everything else anonymously,
 to:
 * regardless of whether you're a bridge or not,
   * do some things non-anonymously,
   * otherwise, do everything else anonymously,

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20077#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online