[tor-bugs] #20333 [Metrics/metrics-lib]: add descriptor digest to vote and streamline method name

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Oct 10 18:31:08 UTC 2016


#20333: add descriptor digest to vote and streamline method name
---------------------------------+-----------------------------------
 Reporter:  iwakeh               |          Owner:  karsten
     Type:  enhancement          |         Status:  new
 Priority:  Medium               |      Milestone:  metrics-lib 1.5.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by karsten):

 Replying to [ticket:20333 iwakeh]:
 > There is currently not vote descriptor digest (so CollecTor calculates
 it on its own).  Most other descriptor types provide a digest.

 Oh, that sounds like an oversight then.  Nobody needed that yet, so it has
 not been implemented.  Let's implement it!

 > In addition, it might be nice to provide a `getDigest` method for the
 different descriptor digests instead of `XyzDescriptor.getXyzDigest`.

 What do you suggest?  Just rename the method and deprecate the old one?
 Is that worth the possible trouble for developers who need to adapt method
 names?  (I just remember how I had to change `shaHex()` to `sha1Hex()` the
 other day and found that change rather annoying.)  And having two methods
 that do the exact same thing seems rather confusing, too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20333#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list