[tor-bugs] #20325 [Metrics/CollecTor]: perform available space check using the partition recent is located on (was: make data directory for available space check configurable)

[Tor Bug Tracker & Wiki]

#20325: perform available space check using the partition recent is located on
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  accepted
 Priority:  Low                |      Milestone:  CollecTor 1.2.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------
Changes (by iwakeh):

 * owner:   => iwakeh
 * status:  new => accepted


Old description:

> Currently, the root path of the configured 'recent' directory is used
> when measuring the available space.
>
> This might not make sense in situations when partitions are mounted
> elsewhere.
> For example:
> {{{
> /dev/sda1 on /      (just the os)
> /dev/sdb1 on /data  (here the 'recent' folder resides somewhere)
> }}}
> In this case sda1 might be small and sdb1 could be the huge data
> partition.  Thus, the measurement of free space for `/` is useless.
>
> Suggestion:
> add `CheckSpacePath` property and default to the root of the recent path
> in case it doesn't exist.

New description:

 Currently, the root path of the configured 'recent' directory is used when
 measuring the available space.

 This might not make sense in situations when partitions are mounted
 elsewhere.
 For example:
 {{{
 /dev/sda1 on /      (just the os)
 /dev/sdb1 on /data  (here the 'recent' folder resides somewhere)
 }}}
 In this case sda1 might be small and sdb1 could be the huge data
 partition.  Thus, the measurement of free space for `/` is useless.

 Suggestion:
 (cf. comments)
 Last resort: add `CheckSpacePath` property and default to the root of the
 recent path in case it doesn't exist.

--

Comment:

 Yes.
 Edited title and text a little to reflect these ideas.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20325#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online