[tor-bugs] #10426 [Applications/Tor Browser]: "new identity" button causes in-progress downloads to be aborted

[Tor Bug Tracker & Wiki]

#10426: "new identity" button causes in-progress downloads to be aborted
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-3.0, tbb-usability, tbb-newnym,  |  Actual Points:
  tbb-easy, tbb-torbutton                        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:9 cypherpunks]:
 > Would it be possible to reuse the warning prompt that Firefox already
 provides when you attempt to quit when a download is in progress?

 I think the text used for that prompt is too focused on "Quit" or "Exit".
 Firefox already has several variations of the text (quit, offline, leave
 private browsing mode), so adding another one seems like the best
 approach. Existing text may be found here:
  https://dxr.mozilla.org/mozilla-esr45/source/toolkit/locales/en-
 US/chrome/mozapps/downloads/downloads.properties#25

 The real work is to patch the Firefox code here to handle the New Identity
 case or to implement a similar prompt in Torbutton:
  https://dxr.mozilla.org/mozilla-
 esr45/source/toolkit/components/downloads/nsDownloadManager.cpp#2454

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10426#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online