[tor-bugs] #20810 [Core Tor/Tor]: protover: Using twice the same version for old tor

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 28 15:52:23 UTC 2016


#20810: protover: Using twice the same version for old tor
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:
         Type:  defect        |     Status:  new
     Priority:  High          |  Milestone:  Tor: 0.3.0.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.2.9.4-alpha
     Severity:  Normal        |   Keywords:  029-backport
Actual Points:                |  Parent ID:
       Points:  0.1           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 `protover_compute_for_old_tor()` checks twice `0.2.7.5` version leading to
 dead code.

 According to the comment and the spec, it should be `0.2.9.1-alpha`.

 {{{
   } else if (tor_version_as_new_as(version, "0.2.7.5")) {
     /* 0.2.9.1-alpha HSRend=2 */
     return "Cons=1-2 Desc=1-2 DirCache=1 HSDir=1 HSIntro=3 HSRend=1-2 "
       "Link=1-4 LinkAuth=1 "
       "Microdesc=1-2 Relay=1-2";
 }}}

 Patch coming up.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20810>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list