[tor-bugs] #20764 [Core Tor/Tor]: Duplicate memset call in tor_addr_from_sockaddr
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Nov 25 15:50:29 UTC 2016
#20764: Duplicate memset call in tor_addr_from_sockaddr
----------------------------+------------------------------------
Reporter: icanhasaccount | Owner:
Type: defect | Status: merge_ready
Priority: Very Low | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Trivial | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: 0.1
Reviewer: | Sponsor:
----------------------------+------------------------------------
Comment (by icanhasaccount):
Thanks for looking at this and thank you for the explanation :)
I could amend the patch to add a comment to tor_addr_from_sockaddr stating
that inner functions should call memset, but as you note it might just be
best to leave as is - the tor_addr_t structure should be quite small so I
doubt its very expensive. Happy either way :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20764#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list