[tor-bugs] #20540 [Metrics]: define log-levels for all java metrics-products

[Tor Bug Tracker & Wiki]

#20540: define log-levels for all java metrics-products
-------------------------+-----------------------------------
 Reporter:  iwakeh       |          Owner:
     Type:  enhancement  |         Status:  needs_information
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+-----------------------------------

Comment (by iwakeh):

 Replying to [comment:5 karsten]:
 > ...
 > >
 > > Maybe, define errors for the unusual (errors would be logged in some
 places where we do not really expect anything) and ask operators to post
 these (ml or trac)?
 >
 > You mean assign a unique error number?  Sure, sounds like a fine idea!
 Should we also do that for warnings, so that operators can give us the
 warning number whenever they're unsure how to handle an issue?

 Assigning a number wouldn't be possible.  I was referring to errors that
 weren't anticipated when coding.  A good example is ticket #20695 where an
 error was caught.  The logged text `ERROR o.t.c.c.CollecTorMain:71 The
 relaydescs module failed: ...` should be `ERROR o.t.c.c.CollecTorMain:71
 Please post this one trac.torproject.org or to the metrics-team mailing
 list. The relaydescs module failed: ...`

 >
 > > Maybe, for metrics-lib we should not log too much but rather throw
 exceptions.  That would be the right way to make the application to deal
 with problems.
 > > But this is "error handling" rather than logging.
 >
 > Well, it touches both areas.  If we say we rather throw an exception
 than log a warning or an error, that's something we can work with.  I
 didn't look at the code yet to see whether that would work.  It might!
 >
 > Agreed with the rest that I didn't quote above.  Let's turn this thread
 into a guide somewhere as soon as we agree on the remaining things.

 I'll add a Logging-wiki page.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20540#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online