[tor-bugs] #17847 [Core Tor/Tor]: Unify router_pick_directory_server_impl and router_pick_trusteddirserver_impl

[Tor Bug Tracker & Wiki]

#17847: Unify router_pick_directory_server_impl and
router_pick_trusteddirserver_impl
---------------------------------------------+-----------------------------
 Reporter:  teor                             |          Owner:
     Type:  enhancement                      |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.0.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  easy, refactor, review-group-12  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Thanks for this patch!

 Many of the macros are missing arguments - it's confusing to have a macro
 use or modify a variable that isn't listed in its arguments.

 Almost all of SKIP_IF_ALREADY_DIR_FETCHING() could become a function,
 except for the body of the if statement, which is small enough to make it
 ok to duplicate.

 Some code just seems to move around or be reformatted - it might be better
 to put whitespace-only changes in their own commit.

 In general, these changes would be easier to review if each refactored
 macro or function was in its own commit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17847#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online