[tor-bugs] #20400 [Core Tor/Tor]: Unreachable code in rend_service_derive_key_digests()

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Nov 22 23:24:36 UTC 2016


#20400: Unreachable code in rend_service_derive_key_digests()
-------------------------------------+------------------------------------
 Reporter:  twim                     |          Owner:
     Type:  defect                   |         Status:  needs_review
 Priority:  Very Low                 |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-hs, review-group-12  |  Actual Points:
Parent ID:                           |         Points:  0.1
 Reviewer:  nickm                    |        Sponsor:  SponsorR-can
-------------------------------------+------------------------------------
Changes (by nickm):

 * reviewer:   => nickm


Comment:

 I'm not sure that computing a pk digest can ever actually fail if we've
 got a private key; can it?  As near as I can tell, both of the warnings
 are unreachable in practice.

 (To answer your question I bet that the "Internal error: " prefix pre-
 dates the LD_BUG domain.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20400#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list