[tor-bugs] #20716 [Core Tor/Tor]: memory leak in connection_handle_listener_read()

[Tor Bug Tracker & Wiki]

#20716: memory leak in connection_handle_listener_read()
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.6.3-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Replying to [comment:7 icanhasaccount]:
 > The other thing is we aren't checking the return code for
 tor_addr_from_sockaddr - not sure if this is an issue though..

 The function can only fail if the family isn't v4, v6, or unix. So it
 can't fail here.

 I wonder if Nick would happily take a patch to clean up all the return
 codes? It seems awfully messy to have a bunch of error handling that we
 should never use though. I wonder if there's a way to refactor (our use
 of) the function so it's never expected to fail?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20716#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online